Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): Deprecate pod-workers. Fixes #4398 #4403

Closed
wants to merge 10 commits into from
Closed

feat(controller): Deprecate pod-workers. Fixes #4398 #4403

wants to merge 10 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 27, 2020 •
edited
Loading

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #4398

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

See #4560

@alexec
feat(controller): Deprecate pod-workers. Fixes argoproj#4398
772d9db 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec closed this Oct 27, 2020
alexec added 3 commits October 27, 2020 12:28
@alexec
no-sig: M workflow/controller/controller.go
22f158a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Merge branch 'master' into no-sig
0907794
@alexec
no-sig: M workflow/controller/controller.go
0c8910e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec reopened this Oct 27, 2020
alexec added 3 commits October 27, 2020 14:15
@alexec
no-sig: M workflow/controller/controller.go
dd58b46 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Merge branch 'master' into no-sig
a97dc27 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Merge branch 'master' into no-sig
1e70013 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Oct 28, 2020

Closing:

  • The removal of significant pod change had no benefit.

@alexec alexec closed this Oct 28, 2020
@alexec alexec deleted the no-sig branch October 28, 2020 17:22
@alexec
Merge branch 'master' into no-sig
c3647b3 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec reopened this Oct 29, 2020
@alexec alexec closed this Oct 30, 2020
@alexec alexec linked an issue Nov 1, 2020 that may be closed by this pull request
v2.10/v2.11/latest(21st Sep): Too many warn & error messages in Argo Workflow Controller (msg="error in entry template execution" error="Deadline exceeded") #4048
Closed
@alexec
Merge branch 'master' into no-sig
7fb97d7 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec reopened this Nov 19, 2020
@alexec
no-sig: M workflow/controller/controller.go
12aae82 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Nov 20, 2020

Shelving until evidence of benefit is reported by users.

@alexec alexec closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@alexec