Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Do not auto-reload doc.location. Fixes #4530 #4535

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 16, 2020

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

Fixes #4530

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

@alexec
Copy link
Contributor Author

alexec commented Nov 16, 2020

TestWFDefaultWithWFTAndWf - not related.

@alexec alexec linked an issue Nov 16, 2020 that may be closed by this pull request
@alexec alexec merged commit 564e69f into argoproj:master Nov 16, 2020
@alexec alexec deleted the docre branch November 16, 2020 17:00
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Dec 2, 2020
…oj#4535)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<ErrorNotice/> timer reload does not work Handle idle timeouts more gracefully
2 participants