Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Use S3 for node offload + workflow archiving. POC #4582

Closed
wants to merge 6 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 22, 2020

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

Testing Instructions

You need to run argoproj/workflow-controller:off-poc with additional configuration:

      # Storage: s3, mysql, or postgres maybe configured.
      #
      # If mulitple are configured then the following rules are used:
      #
      # 1. For node status offloading, S3 is most preference, for archiving, least prefered.
      # 2. MySQL is prefered to PostgreSQL
      #
      # S3 is most prefered (and therefore implicitly recommeded) as it can be expected to be faster,
      # and relies less on the querying capability of an SQL database.
      #
      # S3 is least prefered for workflow archiving. While is is easier to set-up that an SQL database, S3 does not
      # support (out of the box) indexed backed (i.e. fast) querying capabilities for listing archived workflows.
      # List operations will be slow when any significant number of workflows are archived.
      # Unlike MySQL or Postgres, S3 enforces TTLs by setting them on the bucket.
      # You MUST configure different buckets for the archive and offloads if you wish to TTL archived workflows.
      s3: |
        nodeStatusOffload: # ... as artifactRepository.s3
        archive: # ... as artifactRepository.s3

See #4560

@alexec alexec linked an issue Nov 23, 2020 that may be closed by this pull request
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Nov 23, 2020

PR fail is due to crdgen.sh. Passes locally.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Dec 3, 2020

Closing PR so it does not distract me.

@alexec alexec closed this Dec 3, 2020
@alexec alexec deleted the off-poc branch December 5, 2020 00:33
@agilgur5 agilgur5 added area/workflow-archive solution/unimplemented This was not implemented, but may be in the future labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow-archive solution/unimplemented This was not implemented, but may be in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive to artifact repository
2 participants