fix: send periodic keepalive packets on eventstream connections #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Argo is operating behind load balancers / ingress controllers that have an idle timeout configured, it's not uncommon to get disconnected and have an error shown in the UI if you're looking at a relatively inactive workflow or workflow list. In the SSE spec, `:\n` is a sequence that you can send to the client which should be ignored by the client, so we can use that to periodically send something in the response without affecting the code in the UI at all. Fixes argoproj#5006 Signed-off-by: Daniel Herman <dherman@factset.com>
dcherman
commented
Feb 12, 2021
| webhookInterceptor(rw, r, gwmux) | ||
| }) | ||
|
|
||
| if os.Getenv("ENABLE_SSE_KEEPALIVE") != "" { |
There was a problem hiding this comment.
Initially, I figured it might be good to stick this behind a feature flag for people to try to make sure we don't blow anything up prior to rolling it out generally.
dcherman
commented
Feb 12, 2021
| rt.t.Stop() | ||
| } | ||
|
|
||
| func (rt *realTicker) Reset(d time.Duration) { |
There was a problem hiding this comment.
None of the existing clock libraries that I found (including the one from apimachinery that's in use elsewhere) properly support mocking the Reset method of a ticker, so I implemented a small shim to enable me to mock it in the tests. We can swap to the apimachinery one in the future if they add support
|
Closing this for the moment while I'm debugging an error I just found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Argo is operating behind load balancers / ingress controllers that have
an idle timeout configured, it's not uncommon to get disconnected and have
an error shown in the UI if you're looking at a relatively inactive workflow
or workflow list.
In the SSE spec,
:\nis a sequence that you can send to the client whichshould be ignored by the client, so we can use that to periodically send
something in the response without affecting the code in the UI at all.
Fixes #5006
Signed-off-by: Daniel Herman dherman@factset.com