Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed width button. Fixes #4973 #6883

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Oct 7, 2021

Fixes #4973

https://fontawesome.com/v5.15/how-to-use/on-the-web/styling/fixed-width-icons

Untitled_.Oct.7.2021.8_27.PM.mp4

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao tczhao changed the title fix(ui): fixed width button fix(ui): fixed width button. Fixes #4973 Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #6883 (d679a79) into master (689ad68) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6883      +/-   ##
==========================================
- Coverage   48.55%   48.50%   -0.05%     
==========================================
  Files         265      265              
  Lines       19220    19250      +30     
==========================================
+ Hits         9332     9337       +5     
- Misses       8839     8860      +21     
- Partials     1049     1053       +4     
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
pkg/apiclient/http1-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-server-client.go 0.00% <0.00%> (ø)
pkg/apiclient/offline-workflow-service-client.go 0.00% <0.00%> (ø)
...ient/argo-kube-workflow-template-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
server/workflow/workflow_server.go 46.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689ad68...d679a79. Read the comment docs.

@sarabala1979 sarabala1979 self-assigned this Oct 7, 2021
@alexec alexec merged commit cca4792 into argoproj:master Oct 7, 2021
This was referenced Oct 15, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizontal/vertical buttons have different dimensions and are a poor UX
3 participants