Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix data transformation example #6901

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

pevers
Copy link
Contributor

@pevers pevers commented Oct 9, 2021

This PR fixes the data transformation example https://github.com/argoproj/argo-workflows/blob/master/examples/data-transformations.yaml by adding a target artifact.

Without this the workflow crashes with:

Error (exit code 64): unable to process data template: unable to process data source: unable to source artifact paths: template artifact location not set

Closes #6900 .

@pevers pevers force-pushed the fix-data-transformation-example branch from 273bedb to 620d77b Compare October 9, 2021 19:21
@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #6901 (1429a75) into master (2fd4b8a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1429a75 differs from pull request most recent head e4f8ad5. Consider uploading reports for the commit e4f8ad5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6901      +/-   ##
==========================================
- Coverage   48.53%   48.53%   -0.01%     
==========================================
  Files         265      265              
  Lines       19259    19259              
==========================================
- Hits         9348     9347       -1     
- Misses       8860     8861       +1     
  Partials     1051     1051              
Impacted Files Coverage Δ
cmd/argo/commands/get.go 58.89% <0.00%> (-0.88%) ⬇️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd4b8a...e4f8ad5. Read the comment docs.

@pevers pevers force-pushed the fix-data-transformation-example branch from 620d77b to a474fcc Compare October 10, 2021 06:11
@pevers pevers changed the title fix: add target artifact to data transformation example fix(docs): fix data transformation example Oct 10, 2021
@sarabala1979 sarabala1979 enabled auto-merge (squash) October 11, 2021 15:00
Signed-off-by: Peter Evers <pevers90@gmail.com>
auto-merge was automatically disabled October 12, 2021 16:55

Head branch was pushed to by a user without write access

@pevers pevers force-pushed the fix-data-transformation-example branch from a474fcc to e4f8ad5 Compare October 12, 2021 16:55
@alexec alexec enabled auto-merge (squash) October 15, 2021 14:44
@alexec alexec disabled auto-merge October 18, 2021 18:28
@alexec alexec merged commit 4524339 into argoproj:master Oct 18, 2021
@pevers pevers deleted the fix-data-transformation-example branch October 18, 2021 20:06
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Peter Evers <pevers90@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
Signed-off-by: Peter Evers <pevers90@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data transformations example errors with 'template artifact location not set'
3 participants