fix: do not delete expr tag tmpl values. Fixes #6909 #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #6921 +/- ##
==========================================
- Coverage 48.53% 48.48% -0.06%
==========================================
Files 265 265
Lines 19259 19259
==========================================
- Hits 9348 9337 -11
- Misses 8860 8873 +13
+ Partials 1051 1049 -2
Continue to review full report at Codecov.
|
sarabala1979
approved these changes
Oct 13, 2021
simster7
reviewed
Oct 14, 2021
| @@ -8,20 +8,26 @@ import ( | |||
| ) | |||
|
|
|||
| func TestExpand(t *testing.T) { | |||
| for i := 0; i < 100; i++ { // loop 100 times, because map ordering is not determisitic | |||
| for i := 0; i < 1; i++ { // loop 100 times, because map ordering is not determisitic | |||
There was a problem hiding this comment.
Mistake here? Either remove the loop + comments or change back to i < 100? @alexec
sarabala1979
pushed a commit
that referenced
this pull request
Oct 19, 2021
sarabala1979
pushed a commit
that referenced
this pull request
Oct 20, 2021
basanthjenuhb
pushed a commit
to basanthjenuhb/argo-workflows
that referenced
this pull request
Oct 23, 2021
…j#6921) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: bjenuhb <basanth_jenuhb@intuit.com>
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
…j#6921) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
ilyagorban-codefresh
added a commit
to codefresh-io/argo-workflows
that referenced
this pull request
Nov 10, 2021
* fix: do not delete expr tag tmpl values. Fixes argoproj#6909 (argoproj#6921) Signed-off-by: Alex Collins <alex_collins@intuit.com> * update image registry * result of `make pre-commit -B` * Retrigger CI pipeline * result of `make codegen -B STATIC_FILES=false` Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Co-authored-by: Ilya Gorban <ilyagorban@Ilyas-MacBook-Pro.local>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #6909