Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): use correct pod.name in retry/podspecpatch scenario. Fixes #7007 #7008

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Oct 21, 2021

Fixes #7007

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #7008 (91a78cd) into master (86ddda5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7008      +/-   ##
==========================================
- Coverage   48.48%   48.47%   -0.02%     
==========================================
  Files         265      265              
  Lines       19273    19273              
==========================================
- Hits         9344     9342       -2     
- Misses       8878     8881       +3     
+ Partials     1051     1050       -1     
Impacted Files Coverage Δ
workflow/controller/operator.go 71.22% <100.00%> (ø)
workflow/controller/workflowpod.go 74.41% <100.00%> (ø)
server/workflow/workflow_server.go 44.41% <0.00%> (-1.33%) ⬇️
cmd/argo/commands/get.go 59.18% <0.00%> (+0.29%) ⬆️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ddda5...91a78cd. Read the comment docs.

@tczhao tczhao marked this pull request as ready for review October 21, 2021 06:42
@alexec alexec merged commit 3f0a531 into argoproj:master Oct 21, 2021
SunSparc pushed a commit to SunSparc/argo-workflows that referenced this pull request Oct 22, 2021
…ixes argoproj#7007 (argoproj#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: Jonathan Duncan <jonathan@nacnud.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
…ixes argoproj#7007 (argoproj#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Nov 4, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
…ixes #7007 (#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with podname v2, pod.name resolves to incorrect name when using specpatch or retry
2 participants