-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add contributor meeting information and fix slack channel #7031
Conversation
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
Codecov Report
@@ Coverage Diff @@
## master #7031 +/- ##
==========================================
+ Coverage 48.49% 48.54% +0.04%
==========================================
Files 265 265
Lines 19281 19281
==========================================
+ Hits 9351 9359 +8
+ Misses 8881 8870 -11
- Partials 1049 1052 +3
Continue to review full report at Codecov.
|
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
|
||
A weekly opportunity for committers and maintainers of Workflows, Events, and Dataflow to discuss their current work and talk | ||
about what’s next. Feel free to join us! For Community Meeting information, minutes and recordings | ||
please [see here](https://bit.ly/argo-data-weekly). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Community Meeting" != "Argo Data Weekly"
Maybe mention both? http://bit.ly/argo-wf-cmty-mtng surely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, great stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The community meeting is documented on the README. My goal was to document the Argo Data Weekly for the contributors. I thought about adding both to the README but decided that contributors come to this file anyways.
Is the header the confusing part? I can change it to ## Contributor Meetings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay text updated in both places
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
…proj#7031) Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com> Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
Signed-off-by: William Van Hevelingen william.vanhevelingen@acquia.com
Tips:
git commit --signoff
.make pre-commit -B
to fix codegen or lint problems.