Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add contributor meeting information and fix slack channel #7031

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Oct 22, 2021

Signed-off-by: William Van Hevelingen william.vanhevelingen@acquia.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #7031 (eb465a3) into master (ba472e1) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7031      +/-   ##
==========================================
+ Coverage   48.49%   48.54%   +0.04%     
==========================================
  Files         265      265              
  Lines       19281    19281              
==========================================
+ Hits         9351     9359       +8     
+ Misses       8881     8870      -11     
- Partials     1049     1052       +3     
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
workflow/controller/operator.go 71.18% <0.00%> (-0.10%) ⬇️
cmd/argo/commands/get.go 59.76% <0.00%> (+0.87%) ⬆️
server/workflow/workflow_server.go 46.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba472e1...eb465a3. Read the comment docs.

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@terrytangyuan terrytangyuan requested a review from alexec October 22, 2021 14:33

A weekly opportunity for committers and maintainers of Workflows, Events, and Dataflow to discuss their current work and talk
about what’s next. Feel free to join us! For Community Meeting information, minutes and recordings
please [see here](https://bit.ly/argo-data-weekly).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Community Meeting" != "Argo Data Weekly"

Maybe mention both? http://bit.ly/argo-wf-cmty-mtng surely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, great stuff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The community meeting is documented on the README. My goal was to document the Argo Data Weekly for the contributors. I thought about adding both to the README but decided that contributors come to this file anyways.

Is the header the confusing part? I can change it to ## Contributor Meetings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay text updated in both places

Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@alexec alexec merged commit d344247 into argoproj:master Oct 22, 2021
@blkperl blkperl deleted the contrib_docs branch October 22, 2021 22:07
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
…proj#7031)

Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
alexec pushed a commit that referenced this pull request Oct 24, 2021
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Nov 4, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants