Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit test TestNewOperation. Fixes #7063 #7069

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Oct 26, 2021

Fixes #7063

tested with go test -count=100 -run=TestNewOperation ./server/event/dispatch

order of pipeline execution (list) may be different from the order of submission due to network delays

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

…ferent to order of submit

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@terrytangyuan terrytangyuan enabled auto-merge (squash) October 26, 2021 15:28
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #7069 (e176242) into master (18c953d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7069   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         265      265           
  Lines       19307    19307           
=======================================
  Hits         9373     9373           
+ Misses       8880     8879    -1     
- Partials     1054     1055    +1     
Impacted Files Coverage Δ
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c953d...e176242. Read the comment docs.

@terrytangyuan terrytangyuan merged commit 31bf57b into argoproj:master Oct 26, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Nov 4, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
…ferent to order of submit (#7069)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestNewOperation might be flakey
3 participants