Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prevent bad commit messages, fix broken builds #7086

Merged
merged 13 commits into from
Oct 28, 2021
Merged

build: prevent bad commit messages, fix broken builds #7086

merged 13 commits into from
Oct 28, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 27, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@argoproj argoproj deleted a comment from codecov bot Oct 28, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@argoproj argoproj deleted a comment from codecov bot Oct 28, 2021
@alexec
Copy link
Contributor Author

alexec commented Oct 28, 2021

timeout waiting for minio?

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #7086 (bf2d528) into master (91671cd) will increase coverage by 0.08%.
The diff coverage is 67.74%.

❗ Current head bf2d528 differs from pull request most recent head d071253. Consider uploading reports for the commit d071253 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7086      +/-   ##
==========================================
+ Coverage   48.51%   48.59%   +0.08%     
==========================================
  Files         265      265              
  Lines       19315    19329      +14     
==========================================
+ Hits         9370     9393      +23     
+ Misses       8893     8882      -11     
- Partials     1052     1054       +2     
Impacted Files Coverage Δ
workflow/controller/agent.go 67.46% <ø> (ø)
workflow/controller/taskset.go 62.76% <57.14%> (ø)
workflow/controller/http_template.go 73.07% <65.00%> (-26.93%) ⬇️
workflow/controller/operator.go 71.54% <100.00%> (+0.39%) ⬆️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-0.30%) ⬇️
server/workflow/workflow_server.go 46.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91671cd...d071253. Read the comment docs.

@alexec alexec changed the title build: fix build build: auto-correct commits, fix broken builds Oct 28, 2021
@alexec alexec changed the title build: auto-correct commits, fix broken builds build: auto-fix commits, fix broken builds Oct 28, 2021
@alexec alexec marked this pull request as ready for review October 28, 2021 02:00
@alexec alexec enabled auto-merge (squash) October 28, 2021 02:00
@alexec alexec requested a review from terrytangyuan October 28, 2021 02:00
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@alexec alexec changed the title build: auto-fix commits, fix broken builds build: prevent bad commit messages, fix broken builds Oct 28, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
hack/git/hooks/commit-msg Outdated Show resolved Hide resolved
@alexec alexec disabled auto-merge October 28, 2021 20:01
@alexec alexec merged commit 0fb1044 into master Oct 28, 2021
@alexec alexec deleted the dev-ci branch October 28, 2021 20:02
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants