fix: Daemon step in running state, but dependents don't start #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
alexec
approved these changes
Oct 31, 2021
workflow/controller/operator.go
Outdated
| if node.TemplateRef != nil { | ||
| tmplCtx, err := woc.createTemplateContext(node.GetTemplateScope()) | ||
| if err != nil { | ||
| woc.markNodePhase(node.Name, wfv1.NodeError, "Failed to create Template context", err.Error()) |
There was a problem hiding this comment.
I think you can use woc.markNodeError? If not, maybe we should add that func.
terrytangyuan
approved these changes
Oct 31, 2021
xlyk
pushed a commit
to xlyk/argo-workflows
that referenced
this pull request
Nov 1, 2021
…oj#7107) * fix: Daemon step in running state, but dependents don't start Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * update Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * updated Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> Signed-off-by: Kyle Hanks <khanks@investvoyager.com>
alexec
pushed a commit
that referenced
this pull request
Nov 17, 2021
* fix: Daemon step in running state, but dependents don't start Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * update Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * updated Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
closes #6379
Don't bother creating a PR until you've done this:
make pre-commit -Bto fix codegen, lint, and commit message problems.Create your PR as a draft.
does not need to pass.
Tips: