fix(controller): default volume/mount to emissary. Fixes #7118 #7125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
mweibel
reviewed
Nov 2, 2021
| volumes = append(volumes, woc.getVolumeDockerSock(tmpl)) | ||
| default: | ||
| volumes = append(volumes, volumeVarArgo) |
There was a problem hiding this comment.
if I may (been working on #6714 so I saw this too): this changes behaviour because Go's switch-case doesn't fallthrough by default. Before only emissary had /var/run/argo as volume, with this change all except Docker have it as volume.
This changes anyway in #6714 (all will have that volume + mount) so I'm not sure how important it is to get the correct behaviour here.
There was a problem hiding this comment.
Correct me if I'm wrong. Because go doesn't fall through by default, we have the following and the behaviour is expected
pns/k8sapi/kubelet:
do nothing
docker:
attach dockerSock
emissary or empty (default):
attach varArgo
There was a problem hiding this comment.
aah, right. My bad. Sorry about the confusion.
alexec
approved these changes
Nov 2, 2021
sarabala1979
pushed a commit
that referenced
this pull request
Dec 15, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
alexec
added a commit
that referenced
this pull request
Dec 17, 2021
This reverts commit 49b3f0c. Signed-off-by: Alex Collins <alex_collins@intuit.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7118
Don't bother creating a PR until you've done this:
make pre-commit -Bto fix codegen, lint, and commit message problems.Create your PR as a draft.
does not need to pass.
Tips: