Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix argo auth token. Fixes #7175 #7186

Merged
merged 9 commits into from
Nov 22, 2021
Merged

fix: Fix argo auth token. Fixes #7175 #7186

merged 9 commits into from
Nov 22, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 9, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #7175

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@dchancogne
Copy link

@alexec Change makes sense.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue Nov 15, 2021 that may be closed by this pull request
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title fix: Prevent nil panic. Fixes #7175 fix: Fix argo auth token. Fixes #7175 Nov 19, 2021
@alexec alexec requested a review from sarabala1979 November 19, 2021 16:49
@alexec alexec marked this pull request as ready for review November 19, 2021 16:49
@alexec alexec enabled auto-merge (squash) November 19, 2021 16:50
@alexec
Copy link
Contributor Author

alexec commented Nov 19, 2021

@sarabala1979 this is a fix for an 11x 👍 regression in v3.2. We should release next week.

@alexec alexec merged commit e045577 into master Nov 22, 2021
@alexec alexec deleted the dev-kc branch November 22, 2021 19:13
alexec added a commit to alexec/argo-workflows that referenced this pull request Nov 24, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argo auth token --verbose segfaults argo auth token fails with http: nil Request.URL error
3 participants