fix: Fix ANSI color sequences escaping #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
approved these changes
Nov 12, 2021
Signed-off-by: Guillaume Fillon <guillaume.fillon@auth0.com>
zirkome
force-pushed
the
fix-wf-ansi-colors
branch
from
ca766ae to
a8708a6
Compare
|
I'm setting this PR as ready for review, it seems like the only failing check is due to some flakiness which I can't retry. |
alexec
pushed a commit
that referenced
this pull request
Nov 17, 2021
Signed-off-by: Guillaume Fillon <guillaume.fillon@auth0.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where an empty regex applied to all log lines would prefix every characters with
\u001b[1m\u001b[43;1m\u001b[37m\u001b[0m(normally used to wrapped RegExp matches for highlighting). This bug removes any formatting made using ANSI color sequences.Before:
After:
Fixes #7189
Signed-off-by: Guillaume Fillon guillaume.fillon@auth0.com