fix: improve feedback to user when submitting a workflow from the CLI w/o a serviceaccount specified #7246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
When submitting a workflow using
argo submit somefile.yaml
, if the workflow does not explicitly specify aspec.serviceAccountName
, the output of the command would look like this:The important bit here is the
ServiceAccount: default
bit. In my case, I have configured a default ServiceAccount in theworkflowDefaults
section of the workflow-controller configmap. This means that my workflow will not run withServiceAccount: default
, but with the ServiceAccount I specified there. See the command below:What did I change?
I changed the string that is returned as the value for
serviceaccount
when no serviceaccount is set. Instead of suggesting the workflow is using thedefault
serviceaccount, it now specifies that no serviceaccount has been set, and we're using a default ServiceAccount instead.Further context
This PR is the result of a Slack discussion between myself and @crenshaw-dev on this particular issue.