Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pod name shown in log when pod deletion #7301

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Nov 30, 2021

Signed-off-by: mikutas 23391543+mikutas@users.noreply.github.com

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@simster7 simster7 merged commit 88cbea3 into argoproj:master Nov 30, 2021
@mikutas mikutas deleted the misleading_pod_deletion_log branch December 1, 2021 11:47
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants