-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix port definitions in examples #7308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were recently changed to strings from ints: https://github.com/argoproj/argo-workflows/pull/4831/files#diff-fbd4cc7bade7a2809ed6ed26bb784529a98b8ef86453e9cec02394be45dce8c7R27
Which is the correct one? cc @kennytrytek
I tested all the examples on 3.1.14, GKE 1.20 - they weren't working. Just checked daemon-nginx on 3.2.4, it fails with: step group deemed errored due to child daemon-nginx-6qcjp[0].nginx-server error: Pod "daemon-nginx-6qcjp-3819426501" is invalid: spec.containers[1].readinessProbe.httpGet.port: Invalid value: "80": must contain at least one letter or number (a-z, 0-9) |
This is my best understanding of where things sit, so I think string is correct. Feel free to correct me if I've missed something. If string doesn't work for those fields, then clearly they shouldn't have been changed. |
I think this PR is probably correct. I think this is just vanilla values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I think this PR does need to fix the DCO and Semantic Pull Request.
Will check that out. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
now my port is defined by a input parameter spec:
templates:
- name: java-service-run
inputs:
parameters:
- name: run-command
- name: port
value: 8080
daemon: true
retryStrategy:
limit: "1"
container:
workingDir: '/work/'
image: jdk:8u333-centos7
command:
- '{{inputs.parameters.run-command}}'
readinessProbe:
tcpSocket:
port: "{{inputs.parameters.port}}"
initialDelaySeconds: 60
periodSeconds: 6
failureThreshold: 30 I try remove |
This PR was superseded by #9207 |
This isn't related to this PR specifically, but is related to one mentioned above: #4831 |
FIx port definition errors in examples.