fix: Skip missed executions if CronWorkflow schedule is changed. Fixes #7182 #7353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
changed the title
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Simon Behar <simbeh7@gmail.com>
|
@alexec enhanced tests, they should no cover all expected behaviors |
alexec
reviewed
Dec 8, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Dec 8, 2021
| @@ -34,6 +36,8 @@ const ( | |||
| ReplaceConcurrent ConcurrencyPolicy = "Replace" | |||
| ) | |||
|
|
|||
| const annotationKeyLatestSchedule = workflow.CronWorkflowFullName + "/last-used-schedule" | |||
There was a problem hiding this comment.
Moving the label here was necessary to avoid import cycles. I believe this is okay because we have full accessor methods and the label is private... this way implementation of the "last used schedule" concept is completely abstracted.
There was a problem hiding this comment.
I think last-used-schedule is more accurate. We're interested in the schedule that was last used to execute a workflow. This may or may not be the previous schedule.
alexec
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7182
Signed-off-by: Simon Behar simbeh7@gmail.com
Don't bother creating a PR until you've done this:
make pre-commit -Bto fix codegen, lint, and commit message problems.Create your PR as a draft.
does not need to pass.
Tips: