Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): ensure valid request path in GetInputArtifactByUID. Fixes #7717 #7730

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

pacoguzman
Copy link
Contributor

@pacoguzman pacoguzman commented Feb 2, 2022

Signed-off-by: Paco Guzman pacoguzmanp@gmail.com
Fixes #7717


Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

@pacoguzman pacoguzman force-pushed the 7717-getinputartifact-panic branch from 18d24bb to 5c3d2ff Compare February 2, 2022 13:26
…equest path

Signed-off-by: Paco Guzmán <pacoguzman@users.noreply.github.com>
@pacoguzman pacoguzman force-pushed the 7717-getinputartifact-panic branch from 5c3d2ff to e21cc60 Compare February 2, 2022 13:31
@pacoguzman pacoguzman changed the title artifacts.(*ArtifactServer).GetInputArtifactByUID ensure valid request path fix: artifacts.(*ArtifactServer).GetInputArtifactByUID ensure valid request path. Fixes #7717 Feb 3, 2022
@pacoguzman pacoguzman marked this pull request as ready for review February 3, 2022 09:23
@alexec alexec merged commit 70715ec into argoproj:master Feb 3, 2022
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
@agilgur5 agilgur5 changed the title fix: artifacts.(*ArtifactServer).GetInputArtifactByUID ensure valid request path. Fixes #7717 fix(artifacts): ensure valid request path in GetInputArtifactByUID. Fixes #7717 Sep 24, 2024
@agilgur5 agilgur5 added area/api Argo Server API area/artifacts S3/GCP/OSS/Git/HDFS etc labels Sep 24, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api Argo Server API area/artifacts S3/GCP/OSS/Git/HDFS etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oss-fuzz: artifacts.(*ArtifactServer).GetInputArtifactByUID panic
3 participants