Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nil pointer for 2.0 workflows #820

Merged

Conversation

mthx
Copy link
Contributor

@mthx mthx commented Apr 3, 2018

No description provided.

@mthx
Copy link
Contributor Author

mthx commented Apr 3, 2018

Looking at the amount of change in get.go since 2.0, I guess it's intentional that it doesn't support 2.0 workflows, but it's puzzling to fail with a nil pointer. Perhaps this PR is the best that can be done?

@gaganapplatix
Copy link
Contributor

Yeah, 2.1 changed completely how the nodes are represented inside the workflow and how dependency is represented between nodes to allow generic support for dag and steps, which is why cli had to change significantly. I think we probably need to help detect this better and not fail with nil pointer. I will work with @jessesuen to figure out the best approach for 2.1

@jessesuen jessesuen merged commit da582a5 into argoproj:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants