Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix influxdb-ci.yml example #821

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

sebdoido
Copy link

@sebdoido sebdoido commented Apr 4, 2018

Currently, with https://github.com/influxdata/influxdb repository, master branch,
influxdb-ci.yml example doesnot work any more.

Some minor fixes through this commit

  • Use golang:1.9.2 image as base image
  • dont use gdm dependency manager any more... switching to dep
  • remove test-cov-influxql section because influxql is no longer generated here
  • remove test-unit resources request section to be able to run on small k8s cluster

Thanks for your review :-)
And thanks for your hard work on Argo, I just start to play with it and it's really awesome !

- Use golang:1.9.2 image as base image
- dont use gdm dependency manager any more... switching to dep
- remove test-cov-influxql section as influxql is no longer generated
  here
- remove test-unit resources request section to be able to run on small
  k8s cluster
@jessesuen
Copy link
Member

Thanks for fixing this! It's been bugging me for a while that this stopped working all of the sudden.

@jessesuen jessesuen merged commit 206451f into argoproj:master Apr 5, 2018
@sebdoido
Copy link
Author

sebdoido commented Apr 5, 2018

👍 😎

icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this pull request Jan 5, 2022
…rgoproj#821 (argoproj#826)

* feat: Simple Authentication for webhook related event sources

* minor

* minor again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants