fix: broken archived workflows ui. Fixes #9614, #9433 #9634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakotalillie
force-pushed
the
archived-workflows
branch
from
2e0abe9 to
882f84b
Compare
Signed-off-by: Dakota Lillie <dakota.lillie@icloud.com>
dakotalillie
force-pushed
the
archived-workflows
branch
from
882f84b to
3b8cc0f
Compare
tooptoop4
approved these changes
Sep 20, 2022
terrytangyuan
approved these changes
Sep 22, 2022
3 tasks
chenyangxueHDU
pushed a commit
to chenyangxueHDU/argo
that referenced
this pull request
Sep 29, 2022
…argoproj#9634) fix: broken archived workflows ui Signed-off-by: Dakota Lillie <dakota.lillie@icloud.com> Signed-off-by: Dakota Lillie <dakota.lillie@icloud.com> Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…argoproj#9634) fix: broken archived workflows ui Signed-off-by: Dakota Lillie <dakota.lillie@icloud.com> Signed-off-by: Dakota Lillie <dakota.lillie@icloud.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dakota Lillie dakota.lillie@icloud.com
Fixes #9614, #9433
Summary
My understanding is that these issues were introduced with #8963. I did not test the archived workflows page when I developed this feature (that's my bad), and some of the CSS changes appear to have impacted the archived workflows page.
This PR is intended to "stop the bleeding" and make the archived workflows page appear normal again. It does not implement the resizable side panel functionality for the archived workflows page. Doing so will require a more significant refactor, since the resizable side panel implementation uses a custom hook, and the components used for the archived workflows page are class components.
I have tested this on Chrome, Firefox, and Safari.
Before
After