Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document 'top level' packages #44

Merged
merged 6 commits into from
Jun 1, 2020
Merged

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented May 29, 2020

No description provided.

@alexmt alexmt requested review from jannfis and dthomson25 May 29, 2020 20:29
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #44 into master will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   52.60%   52.58%   -0.02%     
==========================================
  Files          25       25              
  Lines        2591     2590       -1     
==========================================
- Hits         1363     1362       -1     
  Misses       1101     1101              
  Partials      127      127              
Impacted Files Coverage Δ
pkg/cache/cluster.go 54.00% <ø> (-0.42%) ⬇️
pkg/cache/resource.go 85.18% <ø> (ø)
pkg/diff/diff.go 59.82% <ø> (ø)
pkg/health/health.go 55.89% <ø> (ø)
pkg/sync/common/types.go 52.17% <ø> (ø)
pkg/sync/sync_context.go 63.35% <66.66%> (ø)
pkg/cache/settings.go 72.00% <100.00%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bd42d...0069d06. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks usable to me! Good job :)

@jannfis jannfis merged commit df17961 into argoproj:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants