Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sync delete option #507

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Feb 14, 2023

Related argoproj/argo-cd#7124
Related argoproj/argo-cd#12448

Signed-off-by: Soumya Ghosh Dastidar gdsoumya@gmail.com

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 55.75% // Head: 55.75% // No change to project coverage 👍

Coverage data is based on head (26f153a) compared to base (917f5a0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   55.75%   55.75%           
=======================================
  Files          41       41           
  Lines        4525     4525           
=======================================
  Hits         2523     2523           
  Misses       1808     1808           
  Partials      194      194           
Impacted Files Coverage Δ
pkg/sync/common/types.go 54.16% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexmt alexmt merged commit ed70eac into argoproj:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants