Skip to content

feat: allow to specify a threshold to control diff sensitivity #546

feat: allow to specify a threshold to control diff sensitivity

feat: allow to specify a threshold to control diff sensitivity #546

Triggered via pull request July 5, 2024 15:19
Status Failure
Total duration 4m 50s
Artifacts 8

ci.yml

on: pull_request
Matrix: e2e-core
Matrix: e2e-cypress
Matrix: e2e-playwright
Matrix: e2e-puppeteer
Matrix: e2e-webdriverio
Matrix: unit
Fit to window
Zoom out
Zoom in

Annotations

10 errors
static: packages/core/src/api-client.test.ts#L53
Property 'threshold' is missing in type '{ key: string; name: string; metadata: null; pwTraceKey: null; }' but required in type '{ key: string; name: string; metadata: ScreenshotMetadata | null; pwTraceKey: string | null; threshold: number | null; }'.
static: packages/core/src/api-client.test.ts#L59
Property 'threshold' is missing in type '{ key: string; name: string; metadata: null; pwTraceKey: null; }' but required in type '{ key: string; name: string; metadata: ScreenshotMetadata | null; pwTraceKey: string | null; threshold: number | null; }'.
static
Process completed with exit code 2.
packages/core/src/upload.test.ts > #upload > uploads: packages/core/src/upload.test.ts#L17
AssertionError: expected { build: { id: '123', …(1) }, …(1) } to deeply equal { build: { id: '123', …(1) }, …(1) } - Expected + Received Object { "build": Object { "id": "123", "url": "https://app.argos-ci.dev/builds/123", }, "screenshots": Array [ Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": null, "name": "penelope.jpg", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/penelope\.jpg$/, "pwTrace": null, + "threshold": null, }, Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": Object { "automationLibrary": Object { "name": "playwright", "version": "1.39.0", }, "browser": Object { "name": "chromium", "version": "119.0.6045.9", }, "colorScheme": "light", "mediaType": "screen", "sdk": Object { "name": "@argos-ci/playwright", "version": "0.0.7", }, "url": "https://localhost:3000/test", "viewport": Object { "height": 768, "width": 1024, }, }, "name": "penelope.png", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/penelope\.png$/, "pwTrace": null, + "threshold": null, }, Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": null, "name": "nested/alicia.jpg", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/nested\/alicia\.jpg$/, "pwTrace": null, + "threshold": null, }, ], } ❯ packages/core/src/upload.test.ts:17:20
unit (20)
Process completed with exit code 1.
packages/core/src/upload.test.ts > #upload > uploads: packages/core/src/upload.test.ts#L17
AssertionError: expected { build: { id: '123', …(1) }, …(1) } to deeply equal { build: { id: '123', …(1) }, …(1) } - Expected + Received Object { "build": Object { "id": "123", "url": "https://app.argos-ci.dev/builds/123", }, "screenshots": Array [ Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": null, "name": "penelope.jpg", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/penelope\.jpg$/, "pwTrace": null, + "threshold": null, }, Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": Object { "automationLibrary": Object { "name": "playwright", "version": "1.39.0", }, "browser": Object { "name": "chromium", "version": "119.0.6045.9", }, "colorScheme": "light", "mediaType": "screen", "sdk": Object { "name": "@argos-ci/playwright", "version": "0.0.7", }, "url": "https://localhost:3000/test", "viewport": Object { "height": 768, "width": 1024, }, }, "name": "penelope.png", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/penelope\.png$/, "pwTrace": null, + "threshold": null, }, Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": null, "name": "nested/alicia.jpg", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/nested\/alicia\.jpg$/, "pwTrace": null, + "threshold": null, }, ], } ❯ packages/core/src/upload.test.ts:17:20
unit (18)
Process completed with exit code 1.
packages/core/src/upload.test.ts > #upload > uploads: packages/core/src/upload.test.ts#L17
AssertionError: expected { build: { id: '123', …(1) }, …(1) } to deeply equal { build: { id: '123', …(1) }, …(1) } - Expected + Received Object { "build": Object { "id": "123", "url": "https://app.argos-ci.dev/builds/123", }, "screenshots": Array [ Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": null, "name": "penelope.jpg", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/penelope\.jpg$/, "pwTrace": null, + "threshold": null, }, Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": Object { "automationLibrary": Object { "name": "playwright", "version": "1.39.0", }, "browser": Object { "name": "chromium", "version": "119.0.6045.9", }, "colorScheme": "light", "mediaType": "screen", "sdk": Object { "name": "@argos-ci/playwright", "version": "0.0.7", }, "url": "https://localhost:3000/test", "viewport": Object { "height": 768, "width": 1024, }, }, "name": "penelope.png", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/penelope\.png$/, "pwTrace": null, + "threshold": null, }, Object { "hash": StringMatching /^[A-Fa-f0-9]{64}$/, "metadata": null, "name": "nested/alicia.jpg", "optimizedPath": Any<String>, "path": StringMatching /__fixtures__\/screenshots\/nested\/alicia\.jpg$/, "pwTrace": null, + "threshold": null, }, ], } ❯ packages/core/src/upload.test.ts:17:20
unit (22)
Process completed with exit code 1.
e2e-cypress (current, ubuntu-latest)
Process completed with exit code 1.

Artifacts

Produced during runtime
Name Size
browser-dist Expired
5.5 KB
cli-dist Expired
1.42 KB
core-dist Expired
8.06 KB
cypress-dist Expired
3.55 KB
playwright-dist Expired
7.69 KB
puppeteer-dist Expired
2.89 KB
util-dist Expired
2.71 KB
webdriverio-dist Expired
2.11 KB