Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send prHeadCommit in @argos-ci/core #50

Closed
gregberge opened this issue Jul 14, 2023 · 0 comments · Fixed by #51
Closed

Send prHeadCommit in @argos-ci/core #50

gregberge opened this issue Jul 14, 2023 · 0 comments · Fixed by #51
Assignees
@gregberge

Comments

@gregberge
Copy link
Member

gregberge commented Jul 14, 2023 •
edited
Loading

Problem is: GitHub uses merge commit by default to run CI tests. Argos uses the branch commit to find the reference branch.

What we want is:

Argos uses the merge commit for everything but it displays the branch commit in UI.

The goal is to set the commit from $GITHUB_SHA and set another variable : prHeadCommit from the head of branch commit.
@gregberge gregberge transferred this issue from argos-ci/argos-ci.com Jul 14, 2023
@gregberge gregberge mentioned this issue Jul 14, 2023
Merged
gregberge added a commit that referenced this issue Jul 14, 2023
@gregberge
feat(core): send prHeadCommit at build creation
919bd89 
Closes #50
@gregberge gregberge linked a pull request Jul 14, 2023 that will close this issue
feat(core): send prHeadCommit at build creation #51
Merged
gregberge added a commit that referenced this issue Jul 14, 2023
@gregberge
feat(core): send prHeadCommit at build creation
2c79db4 
Closes #50
gregberge added a commit that referenced this issue Jul 14, 2023
@gregberge
feat(core): send prHeadCommit at build creation
bcd0fa7 
Closes #50
@gregberge gregberge self-assigned this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregberge gregberge

Labels
None yet
Projects
Argos Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): send prHeadCommit at build creation argos-ci/argos-javascript
1 participant
@gregberge