Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't modify IFRAME to avoid reloads #155

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrzej-woof
Copy link

Description

Altering IFRAME element causes playwright to re-render contents while taking screenshot which may result in unstable screenshots.

Type of changes

bug

Checklist

Valid all before asking for a code review to argos-ci/code :

  • I have read the CONTRIBUTING doc - I believe the doc is not present in this repo ;)
  •  The commits message follows the Conventional Commits' policy
  • Lint and unit tests pass locally
  • I have added tests if needed

Optional checks:

  • My changes requires a change to the documentation
  • I have updated the documentation accordingly

Further comments

Optional : Feel free to explain your motivation, share useful information or a feature screenshot.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
argos-js-sdk-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 1:17pm

@gregberge
Copy link
Member

@andrzej-woof could you please fix format? I can't push on your branch for a reason I ignore.

@andrzej-woof
Copy link
Author

@gregberge should be fixed now
sorry, I was doing the change via github web editor and I had actions disabled in my fork so it did not complain about format :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants