Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The document.body can be undefined when using toMatch #9

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

rzane
Copy link
Contributor

@rzane rzane commented Mar 8, 2018

TypeError: Cannot read property 'textContent' of null

Also, thank you for finally making Jest with Puppeteer feasible. I tried setting this up a few times before and had a really hard time.

@gregberge
Copy link
Member

@rzane when does it happen?

@rzane
Copy link
Contributor Author

rzane commented Mar 8, 2018

I have a server-rendered application with some React sprinkled in. I came across this issue when I submitted a form and expected the resulting page to have a flash message.

I am fairly certain that this could also happen if you were to click a link. You probably wouldn't come across this if you've been testing an SPA.

@gregberge gregberge merged commit 0c60970 into argos-ci:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants