add support for rendering LaneMarkType.SOLID_DASH_WHITE in EgoViewMapRenderer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,15 +125,15 @@ def render_lane_boundary_egoview( | |||
| dash_interval_m=DASH_INTERVAL_M, | |||
| ) | |||
|
|
|||
| elif (mark_type == LaneMarkType.SOLID_DASH_YELLOW and side == "right") or ( | |||
| elif (mark_type in [LaneMarkType.SOLID_DASH_WHITE, LaneMarkType.SOLID_DASH_YELLOW] and side == "right") or ( | |||
There was a problem hiding this comment.
Thanks for the PR, @johnlambert-argo. What are your thoughts on defining the valid line types as:
VALID_MARK_TYPES = set([LaneMarkType.SOLID_DASH_WHITE, LaneMarkType.SOLID_DASH_YELLOW]) (or whichever variable name is suitable)
and then reusing this set on line 128 and 136?
There was a problem hiding this comment.
Thanks for taking a look Ben. Technically, all the lane types are valid types, but only one will be used for any boundary. We could use an alias like SOLID_DASH_TYPES here, but I think it might be more readable to just list out directly.
benjaminrwilson
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add support for rendering LaneMarkType.SOLID_DASH_WHITE in EgoViewMapRenderer. This is a very rare marking type, but does appear in the AV2 Sensor Dataset.
Testing
In order to ensure this PR works as intended, it is:
Compliance with Standards
As the author, I certify that this PR conforms to the following standards: