chore: Clean up Microsoft licensing #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
requested changes
Aug 30, 2023
There was a problem hiding this comment.
We actually need to reproduce the MS license, it's against the license terms to remove it.
The correct way is to indeed insert our (c) but move Microsoft's to a 3d-party notice file.
See d58bf7e for an example (on a different branch of this repo)
Cherry-picked from 6692fed
samuelburnham
force-pushed
the
license-cleanup
branch
from
63c38c5
to
4abb460
Compare
huitseeker
approved these changes
Sep 22, 2023
Comment on lines
+32
to
+41
| ------------------------------------------------------------ | ||
| https://github.com/espressosystems/jellyfish | ||
| https://github.com/han0110/plonkish/ | ||
| https://github.com/espressosystems/hyperplonk | ||
|
|
||
| Licensed under MIT | ||
|
|
||
| MIT License | ||
|
|
||
| Copyright (c) 2022 Espresso Systems, han0110 |
There was a problem hiding this comment.
This branch technically contains none of these but eh, the discrepancy should self correct soon enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes confusion relating to Microsoft licensing/policies. I'm not exactly sure what the right protocol is for a long-lived fork, please suggest any changes.