refactor: replace scalar_product function with an inline fold opera…

…tion (#200)
argumentcomputer · Jun 28, 2023 · e51b866 · e51b866
1 parent 308cc53
commit e51b866
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/circuit2_witness.rs b/src/circuit2_witness.rs
@@ -234,7 +234,10 @@ where
 
                 // sparse mds
                 {
-                    elements_buffer[0] = scalar_product(elements, &m.w_hat);
+                    elements_buffer[0] = elements
+                        .iter()
+                        .zip(&m.w_hat)
+                        .fold(Scalar::ZERO, |acc, (&x, &y)| acc + (x * y));
 
                     for j in 1..width {
                         elements_buffer[j] = elements[j] + elements[0] * m.v_rest[j - 1];
@@ -315,12 +318,6 @@ where
     }
 }
 
-fn scalar_product<Scalar: PrimeField>(a: &[Scalar], b: &[Scalar]) -> Scalar {
-    a.iter()
-        .zip(b)
-        .fold(Scalar::ZERO, |acc, (&x, &y)| acc + (x * y))
-}
-
 #[cfg(test)]
 mod test {
     use super::*;