Wasm support #139
Merged
Wasm support #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Anderssorby
commented
Mar 15, 2022
•
Anderssorby
commented
- Integrate bellperson wasm update
- Fix clippy warnings
Upgrade crates and nix setup
porcuquine
reviewed
Apr 20, 2022
vmx
reviewed
Apr 22, 2022
rust-toolchain
Outdated
| @@ -1 +1 @@ | |||
| 1.56.0 | |||
| 1.60.0 | |||
There was a problem hiding this comment.
I personally leave it at the current version, unless it won't work without an upgrade. But that's a matter of taste, hence no blocker.
vmx
reviewed
Apr 22, 2022
| @@ -8,7 +8,7 @@ license = "MIT OR Apache-2.0" | |||
|
|
|||
| [dependencies] | |||
| lazy_static = "1.4.0" | |||
| bellperson = "0.18.0" | |||
| bellperson = { version = "0.20.0", default-features = false } | |||
There was a problem hiding this comment.
The cuda and opencl feature should also set bellperson/cuda resp. bellperson/opencl.
porcuquine
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.