Implement serde for PoseidonConstants #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
reviewed
Nov 17, 2022
porcuquine
reviewed
Nov 17, 2022
vmx
reviewed
Nov 18, 2022
src/serde_impl.rs
Outdated
Comment on lines
33
to
34
| state.serialize_field("fr", &self.full_rounds)?; | ||
| state.serialize_field("pr", &self.partial_rounds)?; |
There was a problem hiding this comment.
I don't know how important the actual names are. I recently looked into the poseidon paper. There those are named r_f and r_p, so perhaps naming them rf and rp would make sense.
samuelburnham
changed the title
porcuquine
reviewed
Nov 18, 2022
porcuquine
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
This looks great, @samuelburnham, thank you. I think it also closes #146. Can you confirm, and if so, comment/close once this merges?
storojs72
pushed a commit
that referenced
this pull request
Jan 12, 2023
* (WIP) Implement serde for PoseidonConstants * Compress struct field names, format * Formatting, clippy * Add serde hashing tests * Remove pasta patch * Remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual serialization is needed for
PoseidonConstantsdue toArity'stypenumparameter, which doesn't have an easy serde implementation but is only used inCType. Serialization is thus skipped forArityand easily calculablePoseidonConstantsfields likedomain_tagandhalf_full_rounds.Once const generics are workable and #125 is merged, we could instead derive serde automatically.