fix: Deactivate G2 precompiles #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
deactivate_g2
branch
from
627a518 to
9939f01
Compare
huitseeker
force-pushed
the
deactivate_g2
branch
4 times, most recently
from
cf86a15 to
e1d8cc7
Compare
huitseeker
force-pushed
the
deactivate_g2
branch
from
4c0eaa3 to
15bd7cc
Compare
wwared
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
The impact is very small, hard to measure since it's on the order of regular measurement noise (around ~2-3 seconds)
I'm ok merging this for now though. I believe this also helps fix the stack overflows/SIGSEGVs in #65
@storojs72: This change requires a re-build of the plonk artifacts (I think)
huitseeker
added a commit
that referenced
this pull request
Jun 24, 2024
* chore: de-activate G2 precompiles * fix: remove duplicate insertion
wwared
pushed a commit
that referenced
this pull request
Jun 24, 2024
* chore: de-activate G2 precompiles * fix: remove duplicate insertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal de-activation of G2 precompiles to ease performance testing