feat: Incorporate downloading Sphinx parameters using AWS cli #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
requested review from
huitseeker,
wwared,
tchataigner and
samuelburnham
storojs72
force-pushed
the
generate-contracts
branch
from
a9c5b41 to
092e842
Compare
There was a problem hiding this comment.
Approved in spirit, though the CI error seems to indicate a need to check whether the artifacts are installed already
Yes. I'm currently re-building new parameters after merging #49, this is a time-consuming process. Once it finishes I can upload new parameters and |
wwared
reviewed
Jun 20, 2024
storojs72
force-pushed
the
generate-contracts
branch
5 times, most recently
from
bd4fceb to
9e2c6ad
Compare
storojs72
force-pushed
the
generate-contracts
branch
from
9e2c6ad to
89ccc1c
Compare
storojs72
force-pushed
the
generate-contracts
branch
from
7cd967f to
95f036b
Compare
samuelburnham
approved these changes
Jun 20, 2024
huitseeker
pushed a commit
that referenced
this pull request
Jun 24, 2024
* feat: Incorporate downloading using AWS cli * chore: SP1 -> Sphinx renaming in Solidity assets * ci: Add S3 credentials (#64) --------- Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
wwared
pushed a commit
that referenced
this pull request
Jun 24, 2024
* feat: Incorporate downloading using AWS cli * chore: SP1 -> Sphinx renaming in Solidity assets * ci: Add S3 credentials (#64) --------- Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces specific version of Sphinx parameters downloaders using
awsutility. This is necessary because our AWS bucket is not shared publicly for security reasons and can be accessed only by us currently.Please refer to AWS documentation for installing the
awsand contact @samuelburnham for getting credentials for our AWS bucket (s3://sphinx-plonk-params)