feat: merge plonk into dev #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchataigner
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
I believe we can merge this once https://github.com/lurk-lab/sphinx/pull/72/files is merged
* feat: Add scaffolding for Plonk verification in Solidity * feat: Add Plonk contract * tests: Add more negative Solidity testing * feat: Add Rust program for Solidity contract generating * chore: Update Cargo.lock * chore: Update Plonk contract according to 'e48c01ec' tag of Sphinx * chore: Formatting * feat: Introduce downloading from our AWS private bucket * feat: Update Foundry project to use sphinx-contracts dependency * chore: Rename SP1 -> Sphinx
Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr>
* feat: Update Sphinx and replace Groth16 with Plonk (#23) * feat: Solidity verification of light client proofs with Plonk (#28) * feat: Add scaffolding for Plonk verification in Solidity * feat: Add Plonk contract * tests: Add more negative Solidity testing * feat: Add Rust program for Solidity contract generating * chore: Update Cargo.lock * chore: Update Plonk contract according to 'e48c01ec' tag of Sphinx * chore: Formatting * feat: Introduce downloading from our AWS private bucket * feat: Update Foundry project to use sphinx-contracts dependency * chore: Rename SP1 -> Sphinx * chore: Add README for Solidity verification * feat: Add CI configuration for Solidity * ci: solidity tests on all PR Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr> * chore: update programs Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr> * docs: move documentation to mdBook Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr> --------- Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr> Co-authored-by: wwared <wwared@users.noreply.github.com> Co-authored-by: Thomas Chataigner <tom.chataigner@yahoo.fr>
- Added a new "aptos" feature to the `aptos-lc` dependency. - Updated the `fixture-generator`'s Cargo.toml file.
tchataigner
force-pushed
the
plonk-rebased2
branch
from
5423ac8 to
d04ad06
Compare
Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr>
wwared
approved these changes
Jun 24, 2024
tchataigner
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR of argumentcomputer/sphinx#72
Rebased variant of #32. Fixes #35
Note
The CI failure is 100% expected. We should re-launch CI once argumentcomputer/sphinx#72 is merged.