Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Range correction (mean phase shift from wrapped phase) sometimes gives opposite correction sign (skips the cycle) that affects the calculation of the shift between overlapping regions, e.g. instead of subtracting 3 radians it adds them up.
This happens in few cases, most of the time works well. I am not sure why this happens in the first place (could it be the ESD applied on one frame and another no?)
Solution:
I found it out that n integer of 2pi jumps with range correction most of the times is very close to the median difference. So if the difference between those two is larger than a PI, then I switch the sign of range correction.
NOTE: still testing if the median difference between connected components is the most robust option for stitching to avoid the above mentioned.
Another changes:
Added check to accept dem and mask input as filename string instead of gdal.object to be able to use dask to run code in parallel.