Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix of range correction bug #378

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Small fix of range correction bug #378

merged 2 commits into from
Aug 9, 2023

Conversation

mgovorcin
Copy link
Collaborator

Description:
Range correction (mean phase shift from wrapped phase) sometimes gives opposite correction sign (skips the cycle) that affects the calculation of the shift between overlapping regions, e.g. instead of subtracting 3 radians it adds them up.

This happens in few cases, most of the time works well. I am not sure why this happens in the first place (could it be the ESD applied on one frame and another no?)

Solution:
I found it out that n integer of 2pi jumps with range correction most of the times is very close to the median difference. So if the difference between those two is larger than a PI, then I switch the sign of range correction.

NOTE: still testing if the median difference between connected components is the most robust option for stitching to avoid the above mentioned.

Another changes:
Added check to accept dem and mask input as filename string instead of gdal.object to be able to use dask to run code in parallel.

@mgovorcin mgovorcin requested review from sssangha and dbekaert August 8, 2023 21:04
@sssangha
Copy link
Collaborator

sssangha commented Aug 9, 2023

Hello @mgovorcin this LGTM. The velocity field derived from the pairs spanning SF bay through 2019 (the subject of the ariaTSsetup notebook) looks good:
Screenshot 2023-08-09 at 11 38 24 AM

I made the sequential stitcher the default. Let me know if there are any further changes you anticipate for now. Otherwise I will merge and thereafter issue a new release.

Copy link
Collaborator

@sssangha sssangha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sssangha sssangha merged commit db942c8 into dev Aug 9, 2023
@sssangha sssangha deleted the sequential_stitcher branch March 15, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants