Remove b perp from tssetup #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove it from the regression tests as well
* remove lookAngle from test validation script * break up ARIA_STANDARD_LAYERS into INTF layers and GEOM layers
sssangha
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we remove the extraction by default of bPerpendicular instead extracting the average over frames into a JSON file. If the user explicitly requests bPerpendicular we will extract it.
For a case with 54 GUNWs, I found a runtime of 29:06.43 with the full bPerp layer extraction and 8:37.83 with just the mean JSON extraction. The JSON extraction of bPerp is done in parallel as well with dask.delayed and threads.