Fix tests in React 16 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests in master were broken on a fresh install (that would use React 16). 1. Replace deprecated div factory. 2. Update tables output. 3. Lock React to ^16 to prevent this kind of issues in the future.
Merged
|
Thanks! I'm merging the table test fixes & package.json update! The div factory was also fixed by @sophiebits , and I merged her fix first, so I'm leaving that out, sorry 😬. <3 |
ariabuckles
added a commit
that referenced
this pull request
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in master were broken on a fresh install (that would use React 16).