fix(highlight): parsing of JUSTEST_DISABLE_SOURCE_HIGHLIGHT is wrong #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the parsing of the `JUSTEST_DISABLE_SOURCE_HIGHLIGHT` environment variable. Now, setting `true`, `True`, `TRUE`, `1`, or `T` will disable source code highlighting, as one would expect given the environment variable's name. Before this fix, only setting it to `false`, `False`, `FALSE`, `0` or `F` would have turned off source code highlighting, which is the exact opposite of the environment variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the parsing of the
JUSTEST_DISABLE_SOURCE_HIGHLIGHTenvironment variable. Now, settingtrue,True,TRUE,1, orTwill disable source code highlighting, as one would expect given the environment variable's name.Before this fix, only setting it to
false,False,FALSE,0orFwould have turned off source code highlighting, which is the exact opposite of the environment variable name.