-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cvprac integration #222
Merged
Merged
Cvprac integration #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change import from module_utils to cvprac lib
Validate with a playbook to upload / update configlets on CV server ``` ansible-playbook playbooks/dc1-upload-configlets.yml -i inventories/emea/inventory.yml PLAY [Build Switch configuration] *************************************************************************************************************** TASK [cvp_configlet_upload : generate intented variables] *************************************************************************************** Saturday 25 July 2020 14:40:34 +0200 (0:00:00.037) 0:00:00.037 ********* Saturday 25 July 2020 14:40:34 +0200 (0:00:00.037) 0:00:00.037 ********* ok: [cv_server] TASK [cvp_configlet_upload : collecting facts from CVP cv_server.] ****************************************************************************** Saturday 25 July 2020 14:40:36 +0200 (0:00:01.625) 0:00:01.663 ********* Saturday 25 July 2020 14:40:36 +0200 (0:00:01.625) 0:00:01.662 ********* ok: [cv_server] TASK [cvp_configlet_upload : create configlets on CVP cv_server.] ******************************************************************************* Saturday 25 July 2020 14:41:12 +0200 (0:00:36.053) 0:00:37.717 ********* Saturday 25 July 2020 14:41:12 +0200 (0:00:36.053) 0:00:37.716 ********* ok: [cv_server] PLAY RECAP ************************************************************************************************************************************** cv_server : ok=3 changed=0 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 Saturday 25 July 2020 14:41:18 +0200 (0:00:06.047) 0:00:43.764 ********* =============================================================================== cvp_configlet_upload --------------------------------------------------- 43.73s ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ total ------------------------------------------------------------------ 43.73s Saturday 25 July 2020 14:41:18 +0200 (0:00:06.047) 0:00:43.763 ********* =============================================================================== cvp_configlet_upload : collecting facts from CVP cv_server. ----------------------------------------------------------------------------- 36.05s cvp_configlet_upload : create configlets on CVP cv_server. ------------------------------------------------------------------------------- 6.05s cvp_configlet_upload : generate intented variables --------------------------------------------------------------------------------------- 1.63s Playbook run took 0 days, 0 hours, 0 minutes, 43 seconds ```
Update cv_facts functions to use cvprac primitive - get_net_element_info_by_device_id --> get_device_by_mac - get_devices_by_container_id --> get_devices_in_container
Fix an issue in cv_device where configlets where not correctly attached to devices.
AVD Testing Phase:
Test environment:
|
titom73
added
module: cv_configlet
Issue related to cv_configlet module
module: cv_container
Issue related to cv_container module
module: cv_device
Issue related to cv_device module
module: cv_facts
Issue related to cv_facts module
module: cv_task
Issue related to cv_task module
module_utils: cv_client
cv_client implementation issue
state: accepted
Issue is part of the development roadmap
status: in-progress
Currently under investigation or implementation
status: testing
PR under testing
labels
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: cv_configlet
Issue related to cv_configlet module
module: cv_container
Issue related to cv_container module
module: cv_device
Issue related to cv_device module
module: cv_facts
Issue related to cv_facts module
module: cv_task
Issue related to cv_task module
module_utils: cv_client
cv_client implementation issue
state: accepted
Issue is part of the development roadmap
status: in-progress
Currently under investigation or implementation
status: testing
PR under testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191 Types of changes
Related Issue(s)
Fix #219
(New version of #221)
Proposed changes
Migrate Modules to CVPRAC:
Docs & repo updates
How to test
Run AVD playbook with a CVP deployment with the following setup
Checklist:
make linting
andmake sanity-lint
).