-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(cv_facts_v3): make image bundle name key usage consistent #513
Fix(cv_facts_v3): make image bundle name key usage consistent #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add an example playbook that feeds the output of cv_facts_v3
with the imageBundle
keyword in it as an input to cv_container_v3
and cv_device_v3
?
92fe4d7
to
3dbd7ba
Compare
3dbd7ba
to
e92e9da
Compare
e92e9da
to
c8029d9
Compare
c8029d9
to
115e0e2
Compare
…https://github.com/colinmacgiolla/ansible-cvp into Fix-(cv_facts_v3)--Make-imageBundle-usage-consistent
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ake-imageBundle-usage-consistent
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Summary
The
cv_facts_v3
was providing information (facts) about the software image bundle assigned to the container or device. The current implementation usedimage_bundle
as the key. This is not compatible with the container/device schema, and inconsistent in usage.This PR updates
cv_facts_v3
to provide the image bundle, using theimageBundle
key, and updates the container schema to have theimageBundle
as a string.#505 updates the schema in the same way for the device level
Related Issue(s)
Fixes #508
Component(s) name
arista.cvp.cv_facts_v3
schema/v3.py
Proposed changes
Change is from
image_bundle: <name of image bundle
toimageBundle: <name of image bundle>
for both devices and containers.How to test
Checklist
User Checklist
Repository Checklist