-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(cv_container_v3): Adding image bundle dictionary to the output. #627
Conversation
961a43e
to
5d4a1e8
Compare
@@ -0,0 +1,42 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the same format as the other molecule tests?
move these tests into a separate playbook and import it in converge.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
parentContainerName: Tenant | ||
|
||
tasks: | ||
- name: "Build Container topology on {{inventory_hostname}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for the following?
- Create a 3 tier topology
- Delete the above topology
- Create a 3 tier topology and attach configlet to one of the containers and remove it
- Create a 3 tier topology and attach image bundles to one of the containers and remove it
- Play around with
apply_mode: loose
andapply_mode: strict
.
Refer to cv_container_v3 for more info on howapply_mode
works.
NOTE:apply_mode
works for both configlets and imageBundle, so we need to test both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
5d4a1e8
to
1e8668e
Compare
TEAM01_LEAFS: | ||
parentContainerName: TEAM01_DC | ||
configlets: | ||
- ATD-INFRA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use our own configlet instead? I don't want to rely on ATD configlets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can use any configlet, whichever is available on your lab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
# TC2 - Create a 3 tier topology and attach configlet to one of the containers and remove it. | ||
# Testing: | ||
# 1. Adding configlet | ||
# 2. Change in configlet with apply_mode: loose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a test to change configlet with apply_mode: strict
as well? This should match the configlets on CVP with what's supplied in configlet
keyword making adds and removes as necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
topology: '{{TOPOLOGY_3_TIER}}' | ||
register: CONFIGLET_ADD | ||
|
||
- name: Testing Added Configlet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get configlet facts from CVP and check if it's applied on the container we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
178dc16
to
5e51ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! worked nicely on AtD!
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
f2fc6b1
to
82f4423
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
3dea395
to
4344e67
Compare
Change Summary
Adding integration tests for cv_conatiner_v3
Related Issue(s)
Fixes #
Component(s) name
arista.cvp.cv_conatiner_v3
Proposed changes
How to test
molecule converge -s cv_container_v3
Checklist
User Checklist
Repository Checklist