Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update and fix dev requirements #702

Merged
merged 9 commits into from
Jul 19, 2024
Merged

CI: Update and fix dev requirements #702

merged 9 commits into from
Jul 19, 2024

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Jul 18, 2024 •
edited
Loading

Change Summary

  • Fix: ansible-core version in runtime and index.md.
  • Bump: ansible-lint>=24.7.0 requirements-dev.txt
  • Add Python pytest 3.12 in test matrix.
  • Created specific pytest requirements, since ansible-lint is not compatible with Python 3.9

@github-actions github-actions bot added the type: dependencies Issue related to repository content label Jul 18, 2024
@carlbuchmann carlbuchmann changed the title Bump: ansible-lint<24.7.0 requirements-dev.txt Bump: ansible-lint>24.7.0 requirements-dev.txt Jul 18, 2024
@carlbuchmann carlbuchmann changed the title Bump: ansible-lint>24.7.0 requirements-dev.txt Bump: ansible-lint>=24.7.0 requirements-dev.txt Jul 18, 2024
@github-actions github-actions bot added the type: Code quality Issue related to code quality in repository label Jul 18, 2024
@github-actions github-actions bot requested a review from sugetha24 July 18, 2024 20:15
@carlbuchmann carlbuchmann requested a review from gmuloc July 18, 2024 20:37
@carlbuchmann carlbuchmann changed the title Bump: ansible-lint>=24.7.0 requirements-dev.txt CI: Update and fix dev requirements Jul 19, 2024
sugetha24
sugetha24 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sugetha24 sugetha24 merged commit 1a761c9 into aristanetworks:devel Jul 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugetha24 sugetha24 sugetha24 approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@carlbuchmann carlbuchmann

Labels
type: Code quality Issue related to code quality in repository type: dependencies Issue related to repository content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlbuchmann @sugetha24