-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(cv_device_v3): Allow cv_device_v3 to handle SN-based decomms #705
Conversation
54a461c
to
d74f91c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 (tested in ATD on 2024.2.0 successfully)
230e385
to
b9c2769
Compare
Quality Gate passedIssues Measures |
Change Summary
Current cv_device_v3 code does not allow to decomm devices defined by serialNumber only. This change allows to dynamically trigger
get_device_facts
based on the usedsearch_key/__search_by
Related Issue(s)
Fixes #704
Component(s) name
arista.cvp.cv_device_v3
Proposed changes
Dynamically assign
device_lookup
proper value based on the usedsearch_key
How to test
arista.cvp.cv_device_v3
withsearch_key: serialNumber
and pass intodevices
single or multiple device(s) with assignedserialNumber
attribute and missingfqdn/hostname
attributeChecklist
User Checklist
Repository Checklist