Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Management cvx enabled #896

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sarunac
Copy link

@sarunac sarunac commented Oct 23, 2024

Description

Anta Tests to verify if Management CVX is enabled or not.
Fixes # (issue id)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sarunac sarunac changed the title Management cvx enabled feat(anta): Management cvx enabled Oct 23, 2024
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #896 will not alter performance

Comparing sarunac:managementCVXEnabled (01a4ca2) with main (a8aeb44)

Summary

✅ 8 untouched benchmarks

Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I know it is not documented but if you can add the example of your test in the examples/tests.yml that would be great (soon to be automated hopefully)

anta/tests/configuration.py Outdated Show resolved Hide resolved
anta/tests/configuration.py Show resolved Hide resolved
anta/tests/configuration.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_configuration.py Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants