Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates for requirements #43

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Minor updates for requirements #43

merged 3 commits into from
Dec 18, 2023

Conversation

JulioPDX
Copy link
Contributor

Updating AVD, CVP, and ansible-core versions

Copy link
Contributor

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do want to make this AVD 4.5 and CVP 3.10.1 now?

@mthiel117
Copy link
Contributor

mthiel117 commented Dec 18, 2023

We should also update the Lab guide's instructions (separate PR) to run the following commands.

pip3 config set global.disable-pip-version-check true
pip3 install "ansible-core<2.15.0"
ansible-galaxy collection install -r requirements.yml
export ARISTA_AVD_DIR=$(ansible-galaxy collection list arista.avd --format yaml | head -1 | cut -d: -f1)
pip3 install -r ${ARISTA_AVD_DIR}/arista/avd/requirements.txt

to become:

pip3 config set global.disable-pip-version-check true
pip3 install -r requirements.txt
ansible-galaxy collection install -r requirements.yml

@mthiel117
Copy link
Contributor

Successful test in ATD Lab with AVD 4.5 and CVP 3.10.1.

All AVD Labs run as desired.

@JulioPDX
Copy link
Contributor Author

We should also update the Lab guide's instructions (separate PR) to run the following commands.

pip3 config set global.disable-pip-version-check true
pip3 install "ansible-core<2.15.0"
ansible-galaxy collection install -r requirements.yml
export ARISTA_AVD_DIR=$(ansible-galaxy collection list arista.avd --format yaml | head -1 | cut -d: -f1)
pip3 install -r ${ARISTA_AVD_DIR}/arista/avd/requirements.txt

to become:

pip3 config set global.disable-pip-version-check true
pip3 install -r requirements.txt
ansible-galaxy collection install -r requirements.yml

The reason I keep it like this is to ensure we always have the correct python packages installed vs maintaining a separate requirments.txt file. We only need this file for the CICD workflow to install ansible-core

Copy link
Contributor

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthiel117 mthiel117 merged commit 8332668 into aristanetworks:main Dec 18, 2023
EricRowles pushed a commit to EricRowles/ci-workshops-avd that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants