Improve printing

[milianw]

here are three patches, I'd like to upstream.

the first one fixes a build-issue when using build-linux.sh with --headless - it is not really related to the other two, but I was to lazy to create a separate pull request just for that... hope you don't mind

then there is one commit that simplifies the handling of qt-patches in the build-helper.sh, namely the patch files are now read from folders. that way, a user can just dump custom patches there and run the deploy script without changes.

finally, there are three new qt 4.8 patches, that leverage this new patch-folder structure. the patches are improve PhantomJS printing capabilities substantially. Most notably, tables are now printed much nicer (thead, tfoot are repeated and there are no more page-breaks inside table rows). Furthermore users can add a custom header/footer to pages by adding some javascript to their page(s):

    <script type="text/javascript">
    var PhantomJSPrinting = {
      // supported units: mm, cm, in, px
      headerHeight : function() { return '1cm'; },
      footerHeight : function() { return '1cm'; },
      // just return any kind of html that make up the header/footer
      // it should not be taller than what is returned in header/footerHeight()
      header: function(currentPage, totalPages) { return currentPage + " / " + totalPages; },
      footer: function(currentPage, totalPages) { return currentPage + " / " + totalPages; }
    };
    </script>

[milianw]

you can see an example .html & .pdf file here:

https://userpage.physik.fu-berlin.de/~milianw/phantomjs/printing/

[ariya]

For reasons described elsewhere, I rather have the issue linked from the commit log. But if you don't have time to add them, I'll try to amend the commit message as I cherry-pick it.

[milianw]

is there a issue for this? I haven't found one.

I'd welcome it if you could just add the "issue: ..." line yourself - sorry for the inconvenience!

[ariya]

Well yeah, technically a feature should be filed in the issue tracker as well (per our Contribution Guide).

[milianw]

so, should I create a new issue? I found http://code.google.com/p/phantomjs/issues/detail?id=63 which is I think at least partially fixed by this - I'd of course also be ok with you just merging these patches with the "issue: ..." line added.

many thanks

[ariya]

Sure, 63 seems to be a representative issue which I can use. Thanks!

[ariya]

I'm going to hold off merging the printing patch that requires global object (that's not a good practice). Once we have a better JS binding machinery, this will be better handled.

This is also a good reason to prepare an issue in the tracker which discuss the problem/solution.

[milianw]

see http://code.google.com/p/phantomjs/issues/detail?id=410&start=100 - could you please elaborate on which "global object" you mean?

[milianw]

partially merged, rest is going to appear in a new mr soon