This repository has been archived by the owner on May 30, 2023. It is now read-only.
Allow to compile phantomjs without touch events in webkit #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this pull request should set ENABLE_TOUCH_EVENTS to 0 by default when building QtWebkit. |
|
Added commit with disabled TOUCH_EVENTS by default. Still may opted in by --qt-config |
|
For the record, I agree with @vitallium. |
|
Should this pull request be fine tuned further in any way? |
|
Squash it into a single commit. Other than that, might just have to wait on @ariya a bit as his family just welcomed a new baby girl into the world. :) |
Fix compilation of webkit without the TOUCH_EVENTS Added missing #if ENABLE(TOUCH_EVENTS) for generated/JSDocument.* files Disabled webkit touch events compilation by default issue: http://code.google.com/p/phantomjs/issues/detail?id=375
|
Congratulation to @ariya :-) |
|
Note: I won't land this one, see https://code.google.com/p/phantomjs/issues/detail?id=375#c11. |
|
Stashed as a patch in commit 63dc1e2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing #if ENABLE(TOUCH_EVENTS)
for generated/JSDocument.* files
issue: http://code.google.com/p/phantomjs/issues/detail?id=375
Just compile with ./build.sh --qt-config "-D ENABLE_TOUCH_EVENTS=0"
Please cherry-pick this change to 1.8 branch for upcoming bug fix release, thx